Re: [PATCH] drivers/net/skfp/pmf.c: Use offsetof() macro

From: Alan Cox
Date: Thu Jul 31 2008 - 19:14:14 EST


On Thu, 31 Jul 2008 18:55:06 +0200
Takashi Iwai <tiwai@xxxxxxx> wrote:

> Self-baked macros cause bunch of compile warnings like below:
>
> CC [M] drivers/net/skfp/pmf.o
> CC net/ipv4/fib_semantics.o
> drivers/net/skfp/pmf.c:86: warning: cast from pointer to integer of different size
> drivers/net/skfp/pmf.c:87: warning: cast from pointer to integer of different size
> ...
>
> Use the standard offsetof() macro instead.
>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

(And this is better than the patch I sent to netdev so Ack in definite
preference to the one I posted)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/