Re: [PATCH] lockdep: change scheduler annotation

From: Ingo Molnar
Date: Thu Jul 31 2008 - 12:35:23 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> While thinking about David's patch it _finally_ dawned on me that
> there is no reason we have a lock class per cpu..

/me arghs too! :)

> Sorry for being dense :-/
>
> The below changes the annotation from a lock class per cpu, to a
> single nested lock, as the scheduler never holds more that 2 rq locks
> at a time anyway.
>
> If there was code requiring holding all rq locks this would not work
> and the original annotation would be the only option, but that not
> being the case, this is a much lighter one.
>
> Compiles and boots on a 2-way x86_64.

applied to tip/sched/urgent - thanks Peter!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/