Re: [PATCH] Missing symbol prefix on vmlinux.lds.h

[Andrew Morton]

On Wed, 30 Jul 2008 20:26:24 -0400 Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote:

> Sorry.
> 
> I got error ARCH=h8300.
> init/main.c:781: undefined reference to `___early_initcall_end'
> 
> Same problem have
> __start___bug_table
> __stop___bug_table
> __tracedata_start
> __tracedata_end
> __per_cpu_start
> __per_cpu_end
> 
> If define symbol in vmlinux.lds, Use VMLINUX_SYMBOL macro.
> VMLINUX_SYMBOL is add prefix charactor.
> 
> Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> 
> ---
>  include/asm-generic/vmlinux.lds.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 6d88a92..04cae96 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -333,9 +333,9 @@
>  #define BUG_TABLE							\
>  	. = ALIGN(8);							\
>  	__bug_table : AT(ADDR(__bug_table) - LOAD_OFFSET) {		\
> -		__start___bug_table = .;				\
> +		VMLINUX_SYMBOL(__start___bug_table) = .;		\
>  		*(__bug_table)						\
> -		__stop___bug_table = .;					\
> +		VMLINUX_SYMBOL(__stop___bug_table) = .;			\
>  	}
>  #else
>  #define BUG_TABLE

Strange.  The code you're fixing there was added by

  commit 7664c5a1da4711bb6383117f51b94c8dc8f3f1cd
  Author: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
  Date:   Fri Dec 8 02:36:19 2006 -0800

     [PATCH] Generic BUG implementation
    

over a year ago.  I doubt if h8300 has been broken for that long, so
something else must have triggered this failure.

Do you know what it was?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/