Re: [patch v3] splice: fix race with page invalidation

[Linus Torvalds]

On Wed, 30 Jul 2008, Miklos Szeredi wrote:
> 
> Take this patch as a bugfix.  It's not in any way showing the way
> forward: as soon as you have the time, you can revert it and start
> from the current state.
> 
> Hmm?

I dislike that mentality.

The fact is, it's not a bug-fix, it's just papering over the real problem.

And by papering it over, it then just makes people less likely to bother 
with the real issue.

For example, and I talked about this earlier - what make syou think that 
the FUSE/NFSD behaviour you don't like is at all valid in the first place?

If you depend on data not being truncated because you have it "in flight", 
tjhere's already something wrong there. It's _not_ just that people can 
see zero bytes in the reply - apparently they can see the file shrink 
before they see the read return. That kind of thing just worries me. And 
it might be a general NFS issue, not necessarily a FUSE one.

So I think your whole approach stinks. I don't agree with the "bug-fix". 
It really smells like a "bug-paper-over".

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/