Re: [PATCH 1/1] cpumask: Change cpumask_of_cpu to usecpumask_of_cpu_map

[Dave Jones]

On Wed, Jul 30, 2008 at 11:37:52AM -0700, Mike Travis wrote:
 
 > >> I've lost the plot on what's going on with these cpumask patches.
 > >> But I just saw this on -rc1.
 > >>
 > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:206:33: error: not addressable
 > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:274:32: error: not addressable
 > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:352:34: error: not addressable
 > >>
 > 
 > After I recreated linux-next the changes all appear to be there now.
 > One problem though, is !SMP config does not build (something about
 > DECLARE_BITMAP with NR_CPUS=1.)  I wasn't sure how to create a constant
 > "(cpumask_t)1" that worked as an lvalue, so the following patch is
 > somewhat a kluge, but fulfills the requirements.
 > 
 > If anyone has a better suggestion, please let me know.
 > 
 > Subject: [PATCH] cpmask: add cpumask_of_cpu(0) for non-SMP
 > 
 >   * Fix cpumask_of_cpu(0) when CONFIG_SMP is not set by providing a
 >     pointer to a cpumask_t with cpu 0 bit set.

confused.  I saw the error above with a make allyesconfig, which
sets CONFIG_SMP=y

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/