Re: [PATCH 1/2] Export get_user_pages_fast

From: Andrew Morton
Date: Wed Jul 30 2008 - 13:51:50 EST


On Wed, 30 Jul 2008 20:39:44 +0300 Adrian Bunk <bunk@xxxxxxxxxx> wrote:

> > On non-CONFIG_HAVE_GET_USER_PAGES_FAST architectures a
> > get_user_pages_fast() call will in fact call get_user_pages().
> >
> > On CONFIG_HAVE_GET_USER_PAGES_FAST architectures, get_user_pages_fast()
> > is a real function. All architectures which implement that function
> > should export it to modules. Hence it should be exported from within
> > generic code.
>
> Are we talking at cross purposes?

Apparently.

> I thought you were talking an error due to a missing function.

Nope.

> If you think about an error where the function is present but only the
> EXPORT_SYMBOL is missing

yup.

> then I get your point (although I do not
> consider it a huge problem).

Me either.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/