Re: [patch 00/31] pci_ids.h, kernel 2.6.27-rc1, sort DEVICE_IDswithin VENDOR_IDs

From: Andrew Morton
Date: Wed Jul 30 2008 - 06:43:13 EST


On Wed, 30 Jul 2008 18:50:50 +1000 mcs6502@xxxxxxxxx wrote:

> From: mcs6502@xxxxxxxxx
> To: unlisted-recipients:;;@imap1.linux-foundation.org (no To-header on input)

Something went wrong with the From: and To: lines.

Jesse wasn't cc'ed?

> Subject: [patch 00/31] pci_ids.h, kernel 2.6.27-rc1, sort DEVICE_IDs within VENDOR_IDs

a) the patch title shouldn't include the kernel version - that
information becomes instantly irrelevant (and soon wrong) as soon as
someone merges the patch.

It is sometimes useful to include this information, but it should
be inside [], so the patch recipient can automatically remove it.

(otoh, the patch _should_ be against latest Linus mainline, so
it's not very useful info).

b) all 31 patches had the same title. This causes numerous
problems. Please think up unique and relevant titles for each
patch.

> Date: Wed, 30 Jul 2008 18:50:50 +1000
> Sender: linux-kernel-owner@xxxxxxxxxxxxxxx
>
> The following 31 patches attempt to bring pci_ids.h back into order.

This patchset will be utterly ghastly for someone to maintain for two
months. The PCI and linux-next trees will be worst hit.

So we either

a) slam it into mainline immediately or

b) ask you to regenerate it during the 2.6.28 merge window or

c) forget the whole idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/