Re: combinatorial explosion in lockdep

From: Peter Zijlstra
Date: Wed Jul 30 2008 - 03:21:28 EST


On Tue, 2008-07-29 at 23:56 -0700, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 29 Jul 2008 21:45:03 -0700 (PDT)
>
> > If we can agree on this as a fix, it should definitely be backported
> > and submitted for -stable :-)
> >
> > ----------------------------------------
> >
> > lockdep: Fix combinatorial explosion in lock subgraph traversal.
>
> So the next problem I run into is that 8192 is not a large
> enough MAX_LOCKDEP_ENTRIES for this larger cpu count boxes.
> 8192 isn't even big enough for my 64 cpu box.
>
> It needs to be scaled by NR_CPUS, or something like that.

Or something like that indeed - if distro kernels are going to be build
using NR_CPUS=4096, then these tables might explode - then again,
lockdep is only enabled on -debug kernels anyway...

So yeah.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/