Re: [PATCH] add iommu_num_pages helper function

From: FUJITA Tomonori
Date: Tue Jul 29 2008 - 05:59:41 EST


On Tue, 29 Jul 2008 11:50:27 +0200
Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> On Tue, Jul 29, 2008 at 04:45:23PM +1000, Stephen Rothwell wrote:
> > Hi Dave,
> >
> > On Mon, 28 Jul 2008 22:24:39 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote:
> > >
> > > sparc64: Fix build after addition of iommu_num_pages() helper.
> >
> > I added this to the end of linux-next for today. Hopefully we will have
> > a fix in Linus' tree tomorrow.
>
> Yes, my fault, sorry for that breakage :-/
> I think moving that function to x86-only code is the best solution for
> now. Before moving it back to generic code we need an architecture
> independent way to find out the IOMMU page size.

Agreed, it fixes both SPARC and POWER breakages.


> FUJITA,
>
> do you want to work on that or should I try to do this and send it to
> you for review?

I've already sent a patch that fixes the breakages in such way:

http://marc.info/?l=linux-kernel&m=121730644704448&w=2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/