[PATCH 0/4] unify arch/x86/kernel/tlb.c

From: Jeremy Fitzhardinge
Date: Tue Jul 29 2008 - 04:05:53 EST


This series converts tlb_32.c and _64.c to use smp_call_function_mask. Having done that, their underlying similarity is plainly revealed, and they can be easily unified.

The result is the removal of ~270 lines of code, most of which was a pair of open-coded versions of what smp_call_function_mask does anyway. The remaining code is much clearer as a result.

I've given these patches some mild testing, and nothing exploded. I'm actually fairly confident in them, since all the complex subtle stuff is now in smp_call_function_mask, so if anything breaks, it's probably going to be in there.

And though I dare not touch it, Voyager could probably be converted to use this code fairly simply as well.

J

--
arch/x86/kernel/Makefile | 2 arch/x86/kernel/entry_64.S | 15 --
arch/x86/kernel/irqinit_64.c | 10 -
arch/x86/kernel/tlb.c | 229 ++++++++++++++++++++++++++++++++++
arch/x86/kernel/tlb_32.c | 191 ----------------------------
arch/x86/kernel/tlb_64.c | 279 ------------------------------------------
arch/x86/kernel/tlb_uv.c | 5 include/asm-x86/irq_vectors.h | 4 include/asm-x86/uv/uv_bau.h | 2 9 files changed, 234 insertions(+), 503 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/