Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code

From: Li Zefan
Date: Mon Jul 28 2008 - 21:32:21 EST


Paul Jackson wrote:
> Li Zefan wrote:
>> - q = kfifo_alloc(number_of_cpusets * sizeof(cp), GFP_KERNEL, NULL);
>
>
> The block comment for rebuild_sched_domains() states:
>
>> ... May take callback_mutex during
>> * call due to the kfifo_alloc() and kmalloc() calls.
>
> I suspect that mention of kfifo_alloc() is no longer correct,
> with your patch. If so, perhaps you could send a little additional
> fix patch, to remove that mention from the comment.
>

Yes, but I just noticed Max removes that comment completely in his patch,
so I guess I can leave it as it is.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/