Re: [PATCH] Remove stray <6> in BogoMIPS printk

From: Ingo Molnar
Date: Mon Jul 28 2008 - 08:24:33 EST



* Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Sun, 2008-07-27 at 23:47 +0530, Rabin Vincent wrote:
> > Remove the extra KERN_INFO which causes this:
> > Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
> > - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > - loops_per_jiffy/(500000/HZ),
> > - (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> > + printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > + loops_per_jiffy/(500000/HZ),
> > + (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> > }
>
> How about just using KERN_CONT and leaving the whitespace
> for a patch that does the entire file?
>
> diff --git a/init/calibrate.c b/init/calibrate.c
> index 7963e3f..51c5cec 100644
> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
> loops_per_jiffy &= ~loopbit;
> }
> }
> - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> + printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> loops_per_jiffy/(500000/HZ),
> (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);

ok - i've applied the patch below. Please send the full-file cleanup as
a separate patch if anyone is interested in doing it.

Ingo

------------>