[PATCH 0/3] ide: /proc/ide/hd*/settings rework

From: Bartlomiej Zolnierkiewicz
Date: Sun Jul 27 2008 - 14:58:29 EST



Hi,

I finally dusted off /proc/ide/hd*/settings rework (this has been laying
on my hdd and waiting for the better days for at least 1.5 year, draft
version even longer like ~3 years... sigh).

The main motivation for doing it is that with infrastructure for private
IDE subsystem requests from Elias Oltmanns (which was merged recently)
and this patchset it should be possible (by using private requests for
device settings) to make IDE locking code a lot saner and get rid of
of ide_spin_wait_hwgroup()-ugliness completely.

Elias if you would like to take care of it please go ahead [ from a quick
look it seems this would mostly require adding new request type, pointing
rq->special to setting's ->get or ->set method and putting setting's type
(read/write -> 1 bit) + argument (int) somewhere inside request but you
probably know better ].

Patches #1-2 are a preparatory cleanups, the main rework is in patch #3.

diffstat:
drivers/ide/ide-cd.c | 20 +--
drivers/ide/ide-disk.c | 94 ++++++++-------
drivers/ide/ide-floppy.c | 39 ++++--
drivers/ide/ide-probe.c | 2
drivers/ide/ide-proc.c | 285 ++++++++++++++---------------------------------
drivers/ide/ide-tape.c | 77 ++++++++----
drivers/ide/ide.c | 25 ++--
drivers/scsi/ide-scsi.c | 54 ++++++--
include/linux/ide.h | 112 ++++++++++++------
9 files changed, 356 insertions(+), 352 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/