Re: [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings

[Mike Frysinger]

On Sun, Jul 27, 2008 at 2:13 AM, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
>
> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> ---
>  drivers/net/bfin_mac.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
> index 4144343..e18a7ee 100644
> --- a/drivers/net/bfin_mac.c
> +++ b/drivers/net/bfin_mac.c
> @@ -614,7 +614,7 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
>         * Is skb->data always 16-bit aligned?
>         * Do we need to memcpy((char *)(tail->packet + 2), skb->data, len)?
>         */
> -       if ((((unsigned int)(skb->data)) & 0x02) == 2) {
> +       if ((((unsigned int)(skb->data)) & 0x01) == 0) {
>                /* move skb->data to current_tx_ptr payload */
>                data = (unsigned int)(skb->data) - 2;
>                *((unsigned short *)data) = (unsigned short)(skb->len);

i think this unrelated hunk slipped in
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/