[PATCH] usb: don't hide bios bug warning

From: Yinghai Lu
Date: Sat Jul 26 2008 - 21:13:19 EST



quirk_usb_disable_handoff will wait a while if there is BIOS bug.
let the end user know the reason for that.

Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>

---
drivers/usb/host/pci-quirks.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Index: linux-2.6/drivers/usb/host/pci-quirks.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/pci-quirks.c
+++ linux-2.6/drivers/usb/host/pci-quirks.c
@@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
msleep(10);
}
if (wait_time <= 0)
- dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "OHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n",
readl(base + OHCI_CONTROL));

@@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
switch (cap & 0xff) {
case 1: /* BIOS/SMM/... handoff support */
if ((cap & EHCI_USBLEGSUP_BIOS)) {
- dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
+ dev_printk(KERN_DEBUG, &pdev->dev,
+ "EHCI: BIOS handoff\n");

#if 0
/* aleksey_gorelov@xxxxxxxxxxx reports that some systems need SMI forced on,
@@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
/* well, possibly buggy BIOS... try to shut
* it down, and hope nothing goes too wrong
*/
- dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "EHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n", cap);
pci_write_config_byte(pdev, offset + 2, 0);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/