Re: [RFC PATCH] of_gpio: implement of_get_gpio_flags()

From: Trent Piepho
Date: Sat Jul 26 2008 - 04:29:22 EST


On Fri, 25 Jul 2008, Anton Vorontsov wrote:
>
> The name seems a bit unfortunate though, because one could read the
> function as it gets gpio flags only (though, we might implement
> this instead, but this way average driver will end up with parsing
> gpios = <> twice).

It is kind of a confusing name. I'd be tempted to just change of_get_gpio,
it's a new function and it's only called from four places so it's not that
hard to change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/