Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resumeserialized

[Henrik Rydberg]

Hello Dmitry,
> 
> Thank you for the changes.  You don't have to track whether device is
> manually suspended or not - usb_submit_urb will fail and that is it.
> 

Perfect.

> Attached are 2 patches. First cleans suspend state tracking as it is not
> really needed and does some formatting and other minor changes and 2nd
> implements runtime pm for the device. Could you please try them and if
> everything still works I will apply the driver.

Patch 1:

  Looking good, just a few comments:

  * I notice that clamp_val is new since 2.6.24.3
  * Regarding the open-fails comment: is EACCES correct?

Patch 2:

  Perfect.

Thank you so much, Dmitry - it's a GO!

Henrik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/