Re: [PATCH 2.6.26-git] Fix oops on remounting nfsroot

From: Atsushi Nemoto
Date: Fri Jul 25 2008 - 10:57:36 EST


On Thu, 24 Jul 2008 14:29:43 -0700, Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote:
> > + if (!options ||
> > + (nfsvers == 4 && options4->version == 1) ||
> > (nfsvers <= 3 && options->version >= 1 &&
> > options->version <= 6))
> > return 0;
>
> The above is almost correct. You need to test for options4 if the
> filesystem is NFSv4.

But options == options4 == raw_data ;)

> Marc Zyngier sent me a patch for the same problem a couple of days ago,
> but I have yet to pass it on to Linus.

OK, I'll wait that patch merged. Thanks.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/