Re: sfx.c driver build failure

From: Ingo Molnar
Date: Fri Jul 25 2008 - 03:33:19 EST



* Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function âefx_probe_interruptsâ:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary â&â operand
>
> Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
> topology_core_siblings() breakage" in linux-next (from the cpus4096
> tree) comments out the offending lines ... With the comment "the
> topology API is a mess right now".

there's a patch from Mike Travis that solves it all from grounds up and
which approach has the ack of Rusty as well, but it's not fully tested
through yet - i will get to it later today.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/