Re: [lockdep warning] AOE / networking: aoenet_xmit:noop_qdisc.q.lock, INFO: inconsistent lock state at 0000000000000370

[David Miller]

From: Ingo Molnar <mingo@xxxxxxx>
Date: Fri, 25 Jul 2008 08:20:09 +0200

> not sure whether it got reported already, but -tip testing triggered 
> this new ATA over Ethernet lockdep warning on latest -git:

Thanks for the report, does this fix it?

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 4ac7e3a..43abd4d 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -736,9 +736,9 @@ static void shutdown_scheduler_queue(struct net_device *dev,
 		dev_queue->qdisc = qdisc_default;
 		dev_queue->qdisc_sleeping = qdisc_default;
 
-		spin_lock(root_lock);
+		spin_lock_bh(root_lock);
 		qdisc_destroy(qdisc);
-		spin_unlock(root_lock);
+		spin_unlock_bh(root_lock);
 	}
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/