Re: [PATCH 4/4] remove <linux/hdreg.h>

[Christoph Hellwig]

On Thu, Jul 24, 2008 at 10:11:52PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 24 July 2008, Christoph Hellwig wrote:
> > On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > It has no in-kernel users now and can be removed.
> > 
> > But beeing an exported header it has userspace users.  Plese keep it
> > and just leave the ioctl defintions as need by userspace in it instead
> > of renaming that part to hdio_ioctls.h.
> 
> Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
> to be commited, sorry that I didn't mark it as such) but what's wrong with
> moving ioctl definitions to hdio_ioctls.h so we have clean separation of
> obsoleted userspace-only stuff & userspace/kernel stuff?

Well, if there was anything kernel-related left in hdreg.h I would
agree to split it, although I'd prefer to move the kernel part out.

But given that you kill all the kernel only bits anyway, just leave
the user interface in hdreg.h even if it's slightly misnamed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/