Re: linux-next: Tree for July 16 (crash on quad core AMD)

From: Tejun Heo
Date: Fri Jul 18 2008 - 20:59:42 EST


Pierre Ossman wrote:
> I just have one objection to your version, and that is that it cannot
> be used to nibble away at the sg list. The _next() call jumps an entire
> page, whereas you sometimes need to consume that page in two different
> sweeps. This could be handled by some external buffer that keeps the
> remainder of the page, but the point of these functions was to keep
> things simple for the callers.

Well, I don't know how often such usages would be necessary. If it's a
very common ops, you can add a param to the next function but frankly I
think it's better to build a inside control structure for that. There's
no need for external buffer, just an inner loop is sufficient.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/