Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATMdriver to request_firmware()

[David Woodhouse]

On Mon, 2008-06-30 at 09:59 -0400, Chas Williams (CONTRACTOR) wrote:
> In message <1214832072.10393.342.camel@xxxxxxxxxxxxxxxxxx>,David Woodhouse writ
> es:
> >On Mon, 2008-06-30 at 09:15 -0400, Chas Williams (CONTRACTOR) wrote:
> >> In message <1214831362.10393.340.camel@xxxxxxxxxxxxxxxxxx>,David Woodhouse w
> >rit
> >> es:
> >> >And wasn't it sba200e_ecd.bin ? 
> >> 
> >> oops.  sparc is big endian.  adding the const we have...
> >
> >You probably still want the ifdefs for MODULE_FIRMWARE().
> 
> i removed the #ifdef's from around MODULE_LICENSE().  there shouldnt
> be any need for #ifdef's around MODULE_FIRMWARE() either.

Unless you put #ifdef CONFIG_SBUS around the
MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/