RE: [PATCH] fix extern inline errors with gcc 4.3.0

[Halevy, Benny]

On Fri 2008-06-27 19:26, Jeff Dike <jdike@xxxxxxxxxxx> wrote:
> On Thu, Jun 26, 2008 at 04:50:51PM +0300, Benny Halevy wrote:
> > -KBUILD_CFLAGS += $(call cc-option,-fno-unit-at-a-time,)
> > +# Disable unit-at-a-time mode on pre-gcc-4.3 compilers, it makes gcc use
> > +# a lot more stack due to the lack of sharing of stacklots:
> > +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions
> > +KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0403 ] ; then \
> > +			echo $(call cc-option,-fno-unit-at-a-time); fi ;)
> 
> How do we know that this patch won't cause the same crash reported in
> http://marc.info/?l=linux-kernel&m=121011722806093&w=2?

I don't know what was the root cause for the crash you mentioned.
FWIW, with these options UML/x86_64 builds on Fedora 9, w/ gcc 4.3.0
and runs well for me.

Benny

> 
> 				Jeff
> 
> -- 
> Work email - jdike at linux dot intel dot com
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/