Re: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users

[Dan Williams]

On Fri, Jun 27, 2008 at 11:24 AM, David Brownell <david-b@xxxxxxxxxxx> wrote:
> On Friday 27 June 2008, Adrian Bunk wrote:
>> The only effect of the HAVE_DMA_ENGINE would be to not show an empty
>> kconfig menu.
>
> Well, no.  It would also make the network layer memcpy "acceleration"
> option unavailable when there was no underlying engine ... similarly
> with other pointless "we don't have that subsystem here" options.
>

Take another look.  NET_DMA depends on DMA_ENGINE which only gets
selected when a dma device driver is selected.  Each driver has its
architecture specific dependency, so the DMADEVICES arch dependency
was completely redundant.

> Plus it would help ensure that the arch dependencies are comprehenible,
> unlike that highmem thing.

The highmem dependency can go away its only purpose is to prevent
hitting the BUILD_BUG_ON in async_xor.c.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/