Re: [PATCH 01/34] AMD IOMMU: add Kconfig entry

[Joerg Roedel]

On Fri, Jun 27, 2008 at 05:25:58PM +0300, Adrian Bunk wrote:
> On Thu, Jun 26, 2008 at 09:27:37PM +0200, Joerg Roedel wrote:
> > This patch adds the Kconfig entry for the AMD IOMMU driver.
> > 
> > Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
> > ---
> >  arch/x86/Kconfig |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index e0edaaa..5a82f18 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -549,6 +549,13 @@ config CALGARY_IOMMU_ENABLED_BY_DEFAULT
> >  	  Calgary anyway, pass 'iommu=calgary' on the kernel command line.
> >  	  If unsure, say Y.
> >  
> > +config AMD_IOMMU
> > +	bool "AMD IOMMU support"
> > +	select SWIOTL
> > +	depends on X86_64 && PCI
> > +	help
> > +	  Select this to get support for AMD IOMMU hardware in your system.
> > +
> >...
> 
> This tells neither what as IOMMU is nor whether my system actually has 
> one.
> 
> Please shortly describe in the help text what an IOMMU is and which
> AMD systems have an IOMMU.
> 
> The goal is that a system administrator building a kernel for his system 
> gets enough information for deciding whether to enable or disable this 
> option.

Ok, I will provide a new help text as an update to this patch series.

Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/