Re: [PATCH] rtc: remove BKL for ioctl()

[Alan Cox]

On Wed, 25 Jun 2008 16:39:28 -0600
Jonathan Corbet <corbet@xxxxxxx> wrote:

> On Sun, 22 Jun 2008 19:55:42 -0700
> David Brownell <david-b@xxxxxxxxxxx> wrote:
> 
> > Remove implicit use of BKL in ioctl() from the RTC framework.
> 
> Looks good, I'll happily put it into the bkl-removal tree.  One
> question, though:
> 
> > +	err = mutex_lock_interruptible(&rtc->ops_lock);
> > +	if (err)
> > +		return -EBUSY;
> > +
> 
> Shouldn't that be -EINTR?

For an ioctl case which should never be blocking for long periods it
shouldn't be _interruptible in the first place, that will just introduce
bizarre and weird bugs in application code.

If there are slow ops they should drop and retake the lock.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/