Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimalin some kernel info printks

[H. Peter Anvin]

Paul Jackson wrote:
> hpa wrote:
> > that would have to be %#10lx.
>
> Hmmm ... the '#' is a good idea, instead of an explicit "0x".
>
> Do we want zero padding as well, with "0#8lx" ?
>
> Zone PFN ranges:
>   DMA      0x00000000 -> 0x00001000
>   DMA32    0x00001000 -> 0x00100000
>   Normal   0x00100000 -> 0x00428000
>
> or right aligned, space padded:
>
> Zone PFN ranges:
>   DMA             0x0 ->     0x1000
>   DMA32        0x1000 ->   0x100000
>   Normal     0x100000 ->   0x428000
>
> I like the zero padding here myself.

Yes, zero padding.

What we really should have is %p produce this format.  For some odd 
reason, right now %p produces numbers without the 0x prefix.

	-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/