Re: [patch 2.6.26-rc7] <linux/bcd.h> space reduction

[Adrian Bunk]

On Mon, Jun 23, 2008 at 12:15:49AM -0700, David Brownell wrote:
> On Sunday 22 June 2008, Adrian Bunk wrote:
> > On Sun, Jun 22, 2008 at 07:54:36PM -0700, David Brownell wrote:
> > > This updates <linux/bcd.h> to define the key routines as static
> > > constant functions, which the macros will then call.
> > > 
> > > 	... Typical per-driver savings top 200 bytes. ...
> > 
> > The patch breaks the compilation:
> 
> Needs to #include <linux/types.h> then; "u8" isn't always known.
> Or maybe just spell it out "unsigned char".
> 
> 
> >	...
> > 
> > Additionally, I'd suggest to make them out-of-line functions 
> > instead of shipping multiple copies in different object files.
> 
> That was one of the options.  I thought I'd start with something
> simpler, and see what folk thought.
> 
> Where would that be ... lib/bcd.c, always linked?

Sounds good.

> And if it goes
> that way I'd prefer bcd2bin() and bin2bcd(), not these names.  A
> small impetus to have LESS SOURCE CODE SHOUTING AT ME.

Sounds good, but start with SHOUTING COMPATIBILITY #DEFINES FOR THE 
EXISTING USERS and either clean them up later or let me do the cleanup.

> - Dave

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/