Re: [PATCH 2/2] 8139too: different style cleanups

From: Harvey Harrison
Date: Sun Jun 15 2008 - 02:51:19 EST


On Sun, 2008-06-15 at 15:56 +0930, David Newall wrote:
> NÃmeth MÃrton wrote:
> > # define DPRINTK(fmt, args...) \
> > - printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
> > + printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
> >
>
> Why change __FUNCTION__ to __func__? I don't even know where __func__
> come from? Assuming that it isn't totally broken, and I'll believe that
> it isn't, then would it be compiler-specific? __FUNCTION__ is standard
> and that's more than enough reason to prefer that form to any
> non-standard variation.

__FUNCTION__ is gcc-specific, __func__ is C99.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/