Re: [RFC][PATCH] kmemcheck: divide and conquer

[Ingo Molnar]

* Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

> Hi,
> 
> I've split the main x86/mm/kmemcheck.c file and made a subdirectory of 
> many files instead.
> 
> I have included the diffstat below, but I think the patch itself is 
> too big for the mailing list. It can instead be viewed at:
> 
> http://www.kernel.org/pub/linux/kernel/people/vegard/patches/0001-kmemcheck-divide-and-conquer.patch
> 
> The RFC part: Is this a good thing to do? I personally hate the 
> 4000-line files that are so commonly found in the kernel, and 
> therefore prefer this split-up. On the other hand, C lacks namespaces, 
> which sometimes leads to some really long and ugly names just to 
> prevent clashes in the future. But it's your call, I'll just do 
> whatever it takes to get in... ;-)

it's a very nice splitup! :-) [ Any Git coordinates to pick it up? ]

such a splitup opens up for future enhancements such as the sharing of 
opcode decoding between kmemcheck, mmiotrace and KVM. It also makes the 
code easier to maintain as there's less risk of patch merge conflicts. 
And not the least, it's easier to read as well if it's split up into 
logical modules.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/