Re: [PATCH] eth_v10.c phy fix

From: Pieter Steyn
Date: Fri Jun 13 2008 - 12:01:17 EST


Ah, I did not consider case when searching...DOH! :]

I've now cc'ed in Jesper who seems to be the maintainer.

Cheers,
Pieter Steyn

> On 6/13/08, Pieter Steyn <pieterste@xxxxxxxxx> wrote:
> Hi guys,
>
> This patch allows you to set phy address parameters through ethtool, like:
>
> /bin/ethtool -s eth0 phyad 8
>
> --- drivers/net/cris/eth_v10.c 2008-06-12 14:12:33.000000000 +0200
> +++ drivers/net/cris/eth_v10.c 2008-06-12 14:19:35.000000000 +0200
> @@ -1430,7 +1430,11 @@
> e100_set_duplex(dev, ecmd->duplex == DUPLEX_HALF ? half : full);
> e100_set_speed(dev, ecmd->speed == SPEED_10 ? 10: 100);
> }
> -
> + //Honor ethtool phy address parameter, which was simply
> discarded before this.
> + if (ecmd->phy_address <= 31)
> + mdio_phy_addr = ecmd->phy_address;
> + else if (ecmd->phy_address == 32)
> + return -ENODEV;
> return 0;
> }
>
> I've searched the MAINTAINERS file and haven't seen anything regarding
> either the source file name or cris. Please consider applying my
> patch to main kernel...
>
> Thanks,
>
> Pieter Steyn
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/