Re: [patch 3/6] x86: use cpuinfo to check for interrupt pendingmessage msr

From: Thomas Gleixner
Date: Fri Jun 13 2008 - 08:39:10 EST


On Fri, 13 Jun 2008, Andreas Herrmann wrote:
> > + /* Family 0x0f models < rev F do not have this MSR */
> > + if (c->x86 == 0x0f && c->x86_model < 0x40)
> > + return 0;
>
> Just some minor nitpicking.
> Older AMD family 0xf CPUs have this Interrupt Pending Message
> Register. But they do not support C1E and thus bits 27 and 28 of this
> MSR are reserved.

So the check can be simplified to always check the MSR for all
family >= 0x0f CPUs ?

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/