Re: [RESEND #3/patch 2.6.26-rc6] net/enc28j60: low power mode

From: Jeff Garzik
Date: Fri Jun 13 2008 - 05:41:20 EST


David Brownell wrote:
Keep enc28j60 chips in low-power mode when they're not in use.
At typically 120 mA, these chips run hot even when idle; this
low power mode cuts that power usage by a factor of around 100.

This version provides a generic routine to poll a register until
its masked value equals some value ... e.g. bit set or cleared.
It's basically what the previous wait_phy_ready() did, but this
version is generalized to support the handshaking needed to
enter and exit low power mode.

Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Claudio Lanconelli <lanconelli.claudio@xxxxxxxxx>
---
Previously sent: 18-May, 19-February; there were several
previous iterations too ...

drivers/net/enc28j60.c | 82 ++++++++++++++++++++++++++++++++++---------------
1 file changed, 58 insertions(+), 24 deletions(-)

I've put these two into my queue, so they are definitely in process now.

For netdev patches it helps to CC me, since not every patch sent solely to netdev@ is a to-be-applied patch, and might be missed -- or quite often, assumed to be a patch that warrants discussion.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/