Re: [RFC] Implement thermal limiting in generic thermal class

[Matthew Garrett]

On Thu, Jun 12, 2008 at 10:25:34AM +0800, Zhang Rui wrote:

> this patch introduce two things that are obsolete in ACPI thermal
> driver, polling and trip point overriding.

Overriding active trip points was pretty much doomed to failure, given 
that the platform can redefine them at any time.

> I'm under the impression that they are known to break some laptops for
> some reason. Len may have comments on this? :p

Polling is known to break in one case, where the laptop provides a 
passive cooling zone that's at around 50 degrees C. The hardware doesn't 
send any notifications, but if you enable polling thermal limiting will 
start at an excessively low temperature. This patch won't affect that 
case. I'm not aware of any other situations where polling has been 
demonstrated to break things, especially when at a frequency as low as 
this. Of course, it's possible that some machines take an excessively 
long time to respond to temperature reads - that's something that could 
be handled without any trouble.

> as cdev->throttle is cleared by default, this may affect the cooling
> devices in the thermal zones that don't enable passive cooling.

Hm, yes, that's a good point and needs rectifying.

> Hmm, I don't think we should enable the force_passive by default.
> IMO, we should just create "passive" attribute for thermal zones without
> a passive trip point, and enable it until user set a valid value.

That would be an option (and certainly better than the current 
situation), but I'd prefer systems to work out of the box where 
possible.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/