Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags

From: Lee Schermerhorn
Date: Wed Jun 11 2008 - 16:42:50 EST


On Wed, 2008-06-11 at 16:32 -0400, Rik van Riel wrote:
> On Wed, 11 Jun 2008 16:28:03 -0400
> Lee Schermerhorn <Lee.Schermerhorn@xxxxxx> wrote:
> > On Wed, 2008-06-11 at 13:01 -0700, Andrew Morton wrote:
> > > On Wed, 11 Jun 2008 14:42:25 -0400
> > > Rik van Riel <riel@xxxxxxxxxx> wrote:
> > >
> > > > Define proper false/noop inline functions for noreclaim page
> > > > flags when !defined(CONFIG_NORECLAIM_LRU)
> > >
> > > I changed that to CONFIG_UNEVICTABLE_LRU.
> >
> > I noticed that the vmstat items [perhaps these will go away] still use
> > "noreclaim".
>
> $ cat /proc/vmstat
> nr_free_pages 3887198
> nr_inactive_anon 5043
> nr_active_anon 2182
> nr_inactive_file 67121
> nr_active_file 49045
> nr_unevictable 0
> nr_mlock 0
>
> Or am I looking at the wrong thing?

Do you have patch 21/24 applied? In 26-rc5-mm1, I see the
noreclaim_pgs_* vmstat items. They're in the patch 21 you just posted,
as well.

Again, we might decide to drop that patch from the merge. I found the
stats useful during debug and test, but I don't know that they provide
any value in the longer term.

Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/