Re: blackfin drivers/net/smc91x.c build error

[Bryan Wu]

On Wed, Jun 11, 2008 at 11:37 AM, Bryan Wu <cooloney@xxxxxxxxxx> wrote:
> On Wed, Jun 11, 2008 at 1:34 AM, Adrian Bunk <bunk@xxxxxxxxxx> wrote:
>> On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
>>> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
>>> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>>> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>>> >> > drivers/net/smc91x.c fails as follows on blackfin:
>>> >> > ...
>>> >> >  CC      drivers/net/smc91x.o
>>> >> > ...
>>> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>>> >> > ...
>>> >>
>>> >> it's a known issue (been known for quite a long time actually).  Bryan
>>> >> has brought this up in the past already.
>>> >
>>> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
>>> > correct or how else should it be resolved?
>>>
>>> Bryan is taking care of it ... it may just stay broken in favor of
>>> waiting for the merge from the net tree.
>>>
>>> > This issue is the only remaining problem preventing that all blackfin
>>> > defconfigs will compile in 2.6.26...
>>>
>>> not really true.
>>>...
>>
>> What other build errors do you get in Linus' tree?
>>
>
> Sorry for jumping in later. I reported this issue 2 months ago.
> http://lkml.org/lkml/2008/4/7/38
>
> And Adrian is right, we need to revert this patch.
>
> Linus, could you please revert it?
> 099c736a470c8080a166e7a089f1e48e15f9947c
> Or I send a patch out to revert it?
>
> Thanks
> -Bryan
>

Oh, sorry for the confusing. we need to recommit the patch to fix this
build breakage.
9e6db60825ef7e7999abc610ce256ba768e58162
"smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade"

Jeff, do you have my this patch in your tree or just we revert the
099c736a470c8080a166e7a089f1e48e15f9947c?

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/