Re: [patch] bondig - arp_interval with low value => Oops.

[Jeff Garzik]

Jay Vosburgh wrote:
> Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
> > Nicolas 2P wrote:
> > > When setting arp_interval parameter to a very low value, delta_in_ticks
> > > for next arp might become 0, causing an infinite loop.
> > >
> > > See http://bugzilla.kernel.org/show_bug.cgi?id=10680
> > >
> > > Same problem for miimon parameter already fixed, but fix might be
> > > enhanced, by using msecs_to_jiffies() function.
> > >
> > > Signed-off-by: Nicolas de PesloÃan <nicolas.2p.debian@xxxxxxx>
> > I don't see an ACK from Jay in my mbox?
> >
> > Certainly looks nicer than adding "? : 1" to each of the remaining two
> > cases.
>
> 	This was accepted a couple of weeks ago; I had to fix a bug in
> the patch, so I'd guess you didn't connect them:
>
> commit 5ce0da8f0386b62345312ec8fed31303732f4220
> Author: Jay Vosburgh <fubar@xxxxxxxxxx>
> Date:   Sat May 17 21:10:07 2008 -0700
>
>     bonding: Use msecs_to_jiffies, eliminate panic

Great, thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html