Re: [2.6 patch] fix BLK_DEV_HD_ONLY on ARM dependencies

From: Bartlomiej Zolnierkiewicz
Date: Tue Jun 10 2008 - 15:16:40 EST


On Tuesday 10 June 2008, Adrian Bunk wrote:
> This patch limits BLK_DEV_HD_ONLY to the ARM platforms offering
> IRQ_HARDDISK, fixing the following compile error on others:
>
> <-- snip -->
>
> ...
> CC drivers/ide/legacy/hd.o
> ...
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_times_out':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: for each function it appears in.)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'do_hd_request':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:661: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_init':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:765: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> make[3]: *** [drivers/ide/legacy/hd.o] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@xxxxxxxxxx>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>

applied, thanks

BTW Could you look into converting your "remove BLK_DEV_HD_ONLY" patch
into "move old hd driver to drivers/block/" one because the old hd driver
still has some uses (as noticed by Alan)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/