Re: [Bug #10614] WARNING: at include/linux/blkdev.h:431 blk_queue_init_tags+0x110/0x11f()

[Jens Axboe]

On Tue, Jun 10 2008, James Bottomley wrote:
> On Tue, 2008-06-10 at 09:42 +0200, Jens Axboe wrote:
> > On Tue, Jun 10 2008, Nick Piggin wrote:
> > > On Sat, Jun 07, 2008 at 10:42:56PM +0200, Rafael J. Wysocki wrote:
> > > > This message has been generated automatically as a part of a report
> > > > of recent regressions.
> > > > 
> > > > The following bug entry is on the current list of known regressions
> > > > from 2.6.25.  Please verify if it still should be listed.
> > > > 
> > > > 
> > > > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10614
> > > > Subject		: WARNING: at include/linux/blkdev.h:431 blk_queue_init_tags+0x110/0x11f()
> > > > Submitter	: J.A. Magallón <jamagallon@xxxxxxx>
> > > > Date		: 2008-05-01 02:50 (38 days old)
> > > > References	: http://lkml.org/lkml/2008/4/30/614
> > > > Handled-By	: Nick Piggin <npiggin@xxxxxxx>
> > > > 		  Jens Axboe <jens.axboe@xxxxxxxxxx>
> > > 
> > > Did Jens fix this up, or...?
> > > 
> > > I don't think it was ever a problem, just a false positive by the
> > > over eager warning code (still, obviously the warning should be
> > > silenced). J.A., how is the latest git tree going for you?
> > 
> > It's not a real problem, but the WARN() is annoying of course. I think
> > James had a patch queued up for the SCSI side, apparently it's not
> > merged yet? CC'ing James.
> 
> Um ... why are you cc'ing me?  Tomo suggested a fix, but you applied
> your own so I didn't apply his:
> 
> commit aa94b5371f6f898558d9fa5690cc6e4bf917a572
> Author: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Date:   Wed May 7 09:27:43 2008 +0200
> 
>     block: adjust tagging function queue bit locking
> 
> Since the date of the fix is after the date of the report, just have the
> reporter reverify with a later kernel.

Goodness, I mistakenly thought we had another issue there and we were
hitting the resize path in blk_queue_init_tags() which will still
(validly) spit out this warning.

J.A. Magallón, can you please verify that later kernels don't contain
the WARN() for you?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/