Re: [RFC PATCH 3/5] mgmcg VM overcommit interface

[Dave Hansen]

On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote:
> 
> +       cgroup_unlock();
> +
> +       count = sprintf(page, "CommitLimit:  %8lu kB\n"
> +                             "Committed_AS: %8lu kB\n",
> +                             K(allowed), K(committed));
> +       ret = simple_read_from_buffer(userbuf, nbytes, ppos, page, count);
> +out:
> +       free_page((unsigned long)page);
> +       return ret;
> +}

I know you're trying to make this look like meminfo, but it does butcher
the sysfs rules a bit.  How about breaking it out into a couple of
files?

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/