Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus

From: Glauber Costa
Date: Tue Jun 10 2008 - 09:06:26 EST


Yinghai Lu wrote:
On Mon, Jun 9, 2008 at 7:46 PM, Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> wrote:
On Mon, 9 Jun 2008, Maciej W. Rozycki wrote:

we need clear_IO_APIC before enable setup error vector, in case there
is wrong setting in ioapic by BIOS...
Fair enough, although it is still interesting why it would only trigger
in the 64-bit mode and why shouldn't the BIOS be fixed instead.
Then again -- what if X86_LOCAL_APIC is set, but X86_IO_APIC is not?

config X86_LOCAL_APIC
def_bool y
depends on X86_64 || (X86_32 && (X86_UP_APIC || ((X86_VISWS ||
SMP) && !X86_VOYAGER) || X86_GENERICARCH))

config X86_IO_APIC
def_bool y
depends on X86_64 || (X86_32 && (X86_UP_IOAPIC || (SMP &&
!(X86_VISWS || X86_VOYAGER)) || X86_GENERICARCH))

for 64bit, those are all set.

for 32bit, may need to null stub if X86_IO_APIC is not set

YH
Fair Enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/