Re: [patch 4/5] sparse: leds-h1940.c: make non-exported symbolsstatic

From: Richard Purdie
Date: Mon Jun 09 2008 - 17:24:27 EST


On Sat, 2008-06-07 at 16:36 +0100, Ben Dooks wrote:
> plain text document attachment (sparse-fix-h1940-leds.patch)
> We do not need to export any of the routines inside
> drivers/leds/leds-h1940.c, so make them all static to
> quieten the sparse output for this driver.
>
> Fixes the following sparse errors:
> drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static?
>
> CC: Richard Purdie <rpurdie@xxxxxxxxx>
> CC: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
> CC: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>
> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>

Queued in the LEDs tree, thanks.

Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/