Re: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path

From: Andrew Victor
Date: Mon Jun 09 2008 - 16:17:21 EST


hi,

>> Then the driver can do
>> if (host->board->ecc_regs)
>> host->ecc = host->board->ecc_regs;
>> else if (regs)
>> host->ecc = ioremap(regs->start, regs->end - regs->start + 1);
>>
>> if (hard_ecc && !host->ecc)
>> printk("Hardware ECC not available\n");
>>
>> Right? I think we use a similar trick in the atmel_serial driver too.
>
> It may be the best solution indeed.

Agreed.


Regards,
Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/