Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on

From: Alan Stern
Date: Mon Jun 09 2008 - 11:44:32 EST


On Mon, 9 Jun 2008, Oliver Neukum wrote:

> Am Montag 09 Juni 2008 17:03:10 schrieb Alan Stern:
> > On Mon, 9 Jun 2008, Pavel Machek wrote:
> >
> > > Besides, it seems to break suspend/resume of printers, and probably
> > > all the drivers that do not have reset_resume() method. That's
> > > actually a regression.
> > >
> > > https://bugzilla.novell.com/show_bug.cgi?id=394820
> >
> > The right way to fix this is to add reset_resume to the printer driver.
>
> reset_resume() is supposed to restore all state. The printer driver does
> not know which state a printer is in, except for the trivial case of the
> printer not being in use, as it doesn't know the meaning of the data
> going to the printer.
>
> You might argue that you deserve what you get when you hibernate
> while printing, but then it makes no sense to implement it anyhow,
> disconnection and reconnection work just as well and are cleaner.
> The same is true for many devices.

In which case the correct approach is the second one I mentioned (which
you omitted in your reply): Make usbcore unbind drivers that don't
support reset_resume.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/