Re: [PATCH] macb: use random mac if stored address in EEPROM isinvalid

From: Haavard Skinnemoen
Date: Sun Jun 08 2008 - 17:10:39 EST


On Wed, 04 Jun 2008 19:44:20 +0200
Sven Schnelle <svens@xxxxxxxxxxxxxx> wrote:

> We should use a random mac address if the EEPROM doesn't contain a valid
> one. This makes life on Boards with unprogrammed EEPROM devices easier.
>
> Signed-off-by: Sven Schnelle <svens@xxxxxxxxxxxxxx>

Hmm. I don't know. How common is this on properly configured boards?

Btw, the macb driver doesn't read any EEPROM. It reads the hardware
registers of the controller because ARM for some bizarre reason insists
on the boot loader passing the MAC address through hardware registers
(despite the fact that the maintainer of the boot loader insists on
_not_ doing that.)

But if assigning a random mac address when a real mac address isn't
available is common practice in netdev-land, I guess this patch fine
with me.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/