Re: [PATCH 5/5] introduce sysctl of throttle

[Andrew Morton]

On Thu, 05 Jun 2008 11:12:16 +0900 kosaki.motohiro@xxxxxxxxxxxxxx wrote:

> introduce sysctl parameter of max task of throttle.
> 
> <usage>
>  # echo 5 > /proc/sys/vm/max_nr_task_per_zone
> </usage>
> 
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> 
> 
> ---
>  include/linux/swap.h |    2 ++
>  kernel/sysctl.c      |    9 +++++++++
>  mm/vmscan.c          |    4 +++-
>  3 files changed, 14 insertions(+), 1 deletion(-)
> 
> Index: b/mm/vmscan.c
> ===================================================================
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -125,9 +125,11 @@ struct scan_control {
>  int vm_swappiness = 60;
>  long vm_total_pages;	/* The total number of pages which the VM controls */
>  
> -#define MAX_RECLAIM_TASKS CONFIG_NR_MAX_RECLAIM_TASKS_PER_ZONE
> +#define MAX_RECLAIM_TASKS vm_max_nr_task_per_zone
>  static LIST_HEAD(shrinker_list);
>  static DECLARE_RWSEM(shrinker_rwsem);
> +int vm_max_nr_task_per_zone __read_mostly
> +       = CONFIG_NR_MAX_RECLAIM_TASKS_PER_ZONE;

It would be nice if we could remove
CONFIG_NR_MAX_RECLAIM_TASKS_PER_ZONE altogether.  Its a pretty obscure
thing and we haven't provided people wait any information which would
permit them to tune it anwyay.

In which case this patch should be folded into [4/5].


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/