Re: [PATCH] Correct type and description of CONFIG_AC97_POWER_SAVE_DEFAULT

[Takashi Iwai]

At Sat, 7 Jun 2008 16:40:07 -0300,
Thadeu Lima de Souza Cascardo wrote:
> 
> On Sat, Jun 07, 2008 at 07:48:16PM +0200, Takashi Iwai wrote:
> > At Sat, 7 Jun 2008 13:22:39 -0300,
> > Thadeu Lima de Souza Cascardo wrote:
> > > 
> > > While CONFIG_HDA_POWER_SAVE_DEFAULT is used as a timeout in seconds,
> > > CONFIG_AC97_POWER_SAVE_DEFAULT simply enables or disables AC97 power
> > > saving.
> > 
> > Thanks for the patch.  However, I can't take this as is.  The reasons
> > are below:
> > 
> > The power_save option takes indeed an integer value, and this kconfig
> > is nothing but its default value.
> > 
> > In your way, it's set always 1 if selected.  This is a very bad choice
> > as power_save value, because you'll turn on/off after one second.
> > This may lead to too frequent click noises. 
> > Thus, even if we need to make it bool, a more sensitive value must be
> > chosen.  And, which value is sensitive is a matter of taste, and you
> > cannot define it alone by yourself.
> > 
> 
> As I said in my comment, that is true for CONFIG_HDA_POWER_SAVE_DEFAULT,
> which is, in fact, used as a number of seconds, and I left that as is.
> The static power_save variable in ac97_codec.c, however, is only used in
> a macro ac97_is_power_save_mode, which, in turn, is only used in two
> if's.

Ah, right.  It's a simply because I forgot to commit the patch
mistakenly.  The power_save option must take integer as its timeout 
value, just like for snd-hda-intel driver, as described in
Documentation/sound/alsa/powersave.txt.

The patch below is already applied to my git tree, thus for the next
release (will be included in linux-next soon).


thanks,

Takashi