Re: [PATCH] kaweth: use request_firmware()

From: Alan Cox
Date: Sat May 31 2008 - 08:50:49 EST


> I was not late to the party. I was the first one using
> request_firmware() and always keeping an eye on drivers using it and
> making sure using it correctly. However drivers sneaked in without
> that I realized it. Mainly because I don't have that hardware and
> reviewing every single driver obviously never happened.

Nothing in the documentation says that it can't have a heirarchical name,
so naturally lots of people did it. They didn't sneak in - they improved
on the interface and evolved it. They did it in a way that didn't upset
anything else (which is why you didn't notice).

No sneaking involved.

> I repeatedly said that no hierarchical namespace should be used (and
> this was a couple of years ago) and now since some developers misuse
> it, it makes it right.

It means by consensus the developer community decided that a heirarchical
namespace was useful. And that is the party you've arrived late for.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/