Re: Question about interrupt routing and irq allocation

From: Jeremy Fitzhardinge
Date: Wed May 28 2008 - 06:41:36 EST


Eric W. Biederman wrote:
- I think using create_irq is a good step.
- I think all vectors are wasted in the case of Xen.

The case I'm discussing now is in hvm domains - ie, fully virtualized PC platform. I'm adding a driver to poke a hole through all the emulated hardware to get directly to the underlying Xen layer so that we can run paravirtual drivers to get better performance. Only the irqs associated with pv drivers will waste their vectors.

- I think we want a individual irq for each xen irq source.
Sparc already does a demux in similar circumstances with
a queue of received MSI messages an a single cpu irq
that these get demuxed from.
If we don't have individual irqs per drivers it will be hard
to share a source base with native drivers.

In this case the sharing is between fully paravirtualized paravirt_ops Xen and pv-on-hvm drivers. In general I want those drivers to look as normal as possible, so they should use irqs in a normal way.

- I think it would be very nice if we could get irqs allocated
in request_irq instead of create_irq (and equivalents).

Something along the lines of passing -1 as the irq, and it would return the allocated irq? It's not clear to me how all that would fit together.

- I think ultimately it makes sense to port the per vector
code to 32bit linux. On single cpu systems the cost should
be just a hair more code, but no extra data structures. We
can easily restrict the irq allocation to allocating the same
vector on all cpus for any old machines that prove flaky with
irq migration.

The code between the two architectures we kept fairly close
in sync when I worked on it so a merge should not be a big deal.

Well, if I find myself at a loose end, I'll have a look at it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/